[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 10/34] block: Fix reopen flag inheritance

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH 10/34] block: Fix reopen flag inheritance
Date: Mon, 11 May 2015 18:04:18 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 08.05.2015 19:21, Kevin Wolf wrote:
When reopening an image, the block layer already takes care to reopen
bs->file as well with recalculated inherited flags. The same must happen
for any other child (most notably missing before this patch: backing

If bs->file (or any other child) didn't originally inherit from bs, e.g.
because it was created separately and then only referenced, it must not
inherit flags on reopen either, so check the inherited_from field before
propagation the reopen down.

VMDK already reopened its extents manually; this code can now be

Signed-off-by: Kevin Wolf <address@hidden>
  block.c      | 13 +++++++++++--
  block/vmdk.c | 28 ++--------------------------
  2 files changed, 13 insertions(+), 28 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]