[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify

From: Chen Gang
Subject: Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using
Date: Tue, 12 May 2015 05:06:53 +0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 5/12/15 00:01, Richard Henderson wrote:
> On 05/10/2015 03:42 PM, Chen Gang wrote:
>> -static __inline unsigned int
>> +static inline uint8_t
>>  get_BFEnd_X0(tilegx_bundle_bits num)
> Do not change these casts to uint8_t.  It's unnecessary churn.

For me, it is enough to return uint8_t, and the caller really treats it
as uint8_t. So for the function declaration, uint8_t is more precise
than unsigned int for return type.

Chen Gang

Open, share, and attitude like air, water, and life which God blessed

reply via email to

[Prev in Thread] Current Thread [Next in Thread]