[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 19/34] qcow2: Make qcow2_update_options() suitab

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 19/34] qcow2: Make qcow2_update_options() suitable for transactions
Date: Tue, 12 May 2015 15:40:17 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 05/08/2015 11:21 AM, Kevin Wolf wrote:
> Before we can allow updating options at runtime with bdrv_reopen(), we
> need to split the function into prepare/commit/abort parts.
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/qcow2.c | 101 
> ++++++++++++++++++++++++++++++++++++++--------------------
>  1 file changed, 67 insertions(+), 34 deletions(-)

In isolation, it looks like a valid conversion, so:

Reviewed-by: Eric Blake <address@hidden>

However, given that we are having a conversation on another thread about
semantics for prepare vs. commit being the action that actually changes
the in-memory representation, is this the correct split for however we
end up resolving that bug?

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]