[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] mirror: correct buf_size
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2] mirror: correct buf_size |
Date: |
Thu, 14 May 2015 12:38:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 14/05/2015 12:29, Wen Congyang wrote:
>
> If buf_size % granularity is not 0, mirror_free_init() will
> do dangerous things.
>
> Signed-off-by: Wen Congyang <address@hidden>
> ---
> block/mirror.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index 58f391a..9521212 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -684,7 +684,7 @@ static void mirror_start_job(BlockDriverState *bs,
> BlockDriverState *target,
> s->is_none_mode = is_none_mode;
> s->base = base;
> s->granularity = granularity;
> - s->buf_size = MAX(buf_size, granularity);
> + s->buf_size = ROUND_UP(buf_size, granularity);
>
> s->dirty_bitmap = bdrv_create_dirty_bitmap(bs, granularity, NULL, errp);
> if (!s->dirty_bitmap) {
>
Reviewed-by: Paolo Bonzini <address@hidden>