[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/9] qapi: Fix generators to report command line
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 5/9] qapi: Fix generators to report command line errors decently |
Date: |
Thu, 14 May 2015 18:40:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 05/11/2015 01:24 AM, Markus Armbruster wrote:
>> Report to stderr, prefix with the program name. Also reject
>> extra arguments.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> ---
>> scripts/qapi.py | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>
>> @@ -999,4 +999,8 @@ def parse_command_line(extra_options = "",
>> extra_long_options = []):
>> do_c = True
>> do_h = True
>>
>> + if len(args) != 0:
>> + print >>sys.stderr, "%s: too many arguments"% sys.argv[0]
>
> Spacing on both sides of %? Or even:
>
> print >>sys.stderr, sys.argv[0] + ": too many arguments"
>
> but trivial enough to keep R-b whatever you decide.
Spacing tidied up, thanks!
- [Qemu-devel] [PATCH 0/9] qapi: Mostly generator cleanups, Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 8/9] qapi: Drop pointless flush() before close(), Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 5/9] qapi: Fix generators to report command line errors decently, Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 1/9] tests: Add missing dependencies on $(qapi-py), Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 3/9] qapi: qapi-commands.py option --type is unused, drop it, Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 9/9] qapi: Inline gen_command_decl_prologue(), gen_command_def_prologue(), Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 4/9] qapi: Factor parse_command_line() out of the generators, Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 6/9] qapi: Turn generators' mandatory option -i into an argument, Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 7/9] qapi: Factor open_output(), close_output() out of generators, Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 2/9] qapi: qapi-event.py option -b does nothing, drop it, Markus Armbruster, 2015/05/11
- Re: [Qemu-devel] [PATCH 0/9] qapi: Mostly generator cleanups, Eric Blake, 2015/05/14