[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/15] tap: net_tap_fd_init() can't fail, drop d

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 05/15] tap: net_tap_fd_init() can't fail, drop dead error handling
Date: Thu, 14 May 2015 10:48:25 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 05/12/2015 06:02 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  net/tap.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)

> @@ -552,14 +551,8 @@ int net_init_bridge(const NetClientOptions *opts, const 
> char *name,
>      }
>      fcntl(fd, F_SETFL, O_NONBLOCK);

Well, fcntl() could fail.  And don't we have the helper function
util/oslib-posix.c:qemu_set_nonblock() for doing this correctly?  (Then
again, that helper also ignores failures).

But the raw use of fcntl here is pre-existing and you didn't touch it,
so it doesn't affect my review of this patch.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]