qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 22/26] qapi: Fix generators to report command line er


From: Markus Armbruster
Subject: [Qemu-devel] [PULL 22/26] qapi: Fix generators to report command line errors decently
Date: Fri, 15 May 2015 10:24:48 +0200

Report to stderr, prefix with the program name.  Also reject
extra arguments.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
 scripts/qapi.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/scripts/qapi.py b/scripts/qapi.py
index b97dd0b..df6e5aa 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -989,7 +989,7 @@ def parse_command_line(extra_options = "", 
extra_long_options = []):
                                         "input-file=", "output-dir="]
                                        + extra_long_options)
     except getopt.GetoptError, err:
-        print str(err)
+        print >>sys.stderr, "%s: %s" % (sys.argv[0], str(err))
         sys.exit(1)
 
     output_dir = ""
@@ -1017,4 +1017,8 @@ def parse_command_line(extra_options = "", 
extra_long_options = []):
         do_c = True
         do_h = True
 
+    if len(args) != 0:
+        print >>sys.stderr, "%s: too many arguments" % sys.argv[0]
+        sys.exit(1)
+
     return (input_file, output_dir, do_c, do_h, prefix, extra_opts)
-- 
1.9.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]