[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/11] qemu-iotests: test overlapping block-stre

From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH 11/11] qemu-iotests: test overlapping block-stream operations
Date: Fri, 15 May 2015 17:18:47 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, 05/15 10:58, Alberto Garcia wrote:
> On Fri 15 May 2015 04:56:09 AM CEST, Fam Zheng wrote:
> >> +        # If node4 is the active node, the id of the block job is drive0
> >> +        if self.num_imgs == 5:
> >
> > Isn't self.num_imgs a constant (9) ?
> Yes, but the number is arbitrary. The idea is to let users change it if
> they want to, so the test case must be prepared for that.

They have to change the code to get a different value, no? This is unreachable
code as is and IMO even if you're not as considerate on this, whoever changes
num_ops should make sure code that uses it still works. This is bikeshedding,
this is a great series, so even if you insist,

Reviewed-by: Fam Zheng <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]