[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] util: socket: Add missing localaddr and loca
Re: [Qemu-devel] [PATCH v2] util: socket: Add missing localaddr and localport option for DGRAM socket
Fri, 15 May 2015 14:24:25 +0200
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
Peter Krempa <address@hidden> writes:
> The 'socket_optslist' structure does not contain the 'localaddr' and
> 'localport' options that are parsed in case you are creating a
> 'connect' type UDP character device.
> I've noticed it happening after commit f43e47dbf6de24db20ec9b588bb6cc762
> made qemu abort() after seeing the invalid option.
> A minimal reproducer for the case is:
> $ qemu-system-x86_64 -chardev
> qemu-system-x86_64: -chardev
> udp,id=charrng0,host=127.0.0.1,port=1234,localaddr=,localport=1234: Invalid
> parameter 'localaddr'
> Aborted (core dumped)
> Prior to the commit mentioned above the error would be printed but the
> value for localaddr and localport was simply ignored. I did not go
> trhough the code to find out when it was broken.
Perhaps this can be touched up on commit.
> Add the two fields so that the options can again be parsed correctly and
> qemu doesn't abort().
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1220252
> Signed-off-by: Peter Krempa <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
File has no maintainer. Adding qemu-trivial.
Reviewed-by: Markus Armbruster <address@hidden>