[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qemu-iotests: Make debugging python tests easie

From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Make debugging python tests easier
Date: Mon, 18 May 2015 09:32:12 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, 05/15 13:48, John Snow wrote:
> On 05/15/2015 01:26 AM, Fam Zheng wrote:
> > Adding "-d" option. The output goes to "tee" so it appears in your
> > console. Also, raise the verbosity of unnitest runner.
> > 
> > When testing a topic branch, it's possible that a bug introduced by a
> > code change makes the python test case hang, with debug output, it is
> > much easier to locate the problem.
> > 
> > This can also be helpful if you want to watch the progress of a python
> > test, it offers you a way to sense the speed of each test case method
> > you're writing.
> > 
> Awesome idea!
> Unfortunately, it explodes when I run ./check -v -d -qcow2 124:
> +Traceback (most recent call last):
> +  File "124", line 363, in <module>
> +    iotests.main(supported_fmts=['qcow2'])
> +  File "/home/bos/jhuston/src/qemu/tests/qemu-iotests/iotests.py", line
> 367, in main
> +    sys.stderr.write(re.sub(r'Ran (\d+) tests? in [\d.]+s', r'Ran \1
> tests', output.getvalue()))
> +AttributeError: 'file' object has no attribute 'getvalue'
> Failures: 124
> Failed 1 of 1 tests
> --js

I guess we can skip this line if debug is True. (However, I should have noted
in the commit message, by specifying "-d", the purpose of the execution is
solely *debugging the test itself*, and because I didn't find a easy way to get
*both* the verbose debug output and an output that would match $seq.out, this
patch always makes a "-d" execution fail.)

Will send another version with an additional "if debug".



reply via email to

[Prev in Thread] Current Thread [Next in Thread]