[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/9] runstate: create runstate_index function
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 4/9] runstate: create runstate_index function |
Date: |
Mon, 18 May 2015 10:58:34 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Juan Quintela (address@hidden) wrote:
> Given a string state, we need a way to get the RunState for that string.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> include/sysemu/sysemu.h | 1 +
> vl.c | 13 +++++++++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index c1a403e..e5fff07 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -29,6 +29,7 @@ void runstate_set(RunState new_state);
> int runstate_is_running(void);
> bool runstate_needs_reset(void);
> int runstate_store(char *str, int size);
> +RunState runstate_index(char *str);
> typedef struct vm_change_state_entry VMChangeStateEntry;
> typedef void VMChangeStateHandler(void *opaque, int running, RunState state);
>
> diff --git a/vl.c b/vl.c
> index 7dca13f..ea4319d 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -620,6 +620,19 @@ int runstate_store(char *str, int size)
> return 0;
> }
>
> +RunState runstate_index(char *str)
> +{
> + RunState i = 0;
> +
> + while (i != RUN_STATE_MAX) {
> + if (strcmp(str, RunState_lookup[i]) == 0) {
> + return i;
> + }
> + i++;
> + }
> + return -1;
It doesn't seem right to return -1 for the value of an enum
(which is otherwise used as an index into an array of strings).
Make it return a bool and pass the RunState* as a parameter ?
Dave
> +}
> +
> static void runstate_init(void)
> {
> const RunStateTransition *p;
> --
> 2.4.0
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 0/9] Optional toplevel sections, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 3/9] runstate: Add runstate store, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 4/9] runstate: create runstate_index function, Juan Quintela, 2015/05/14
- Re: [Qemu-devel] [PATCH 4/9] runstate: create runstate_index function,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 5/9] runstate: migration allows more transitions now, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 1/9] migration: create savevm_state, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 6/9] migration: create new section to store global state, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 7/9] global_state: Make section optional, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 8/9] vmstate: Create optional sections, Juan Quintela, 2015/05/14