[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH v3 00/13] main-loop: Get rid of fd_

From: Fam Zheng
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2
Date: Wed, 20 May 2015 14:38:03 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Wed, 05/20 08:26, Paolo Bonzini wrote:
> On 19/05/2015 17:02, Stefan Hajnoczi wrote:
> > 1. Convert everything like you converted qemu-nbd.c.  This is a 
> > conservative approach and we can be confident that behavior is 
> > unchanged.
> So, that means whenever you change receive_disabled you call a new
> callback on the peer?  In addition, whenever the count of
> receive-disabled ports switches from zero to non-zero or vice versa,
> hubs need to inform all its ports.
> There are just two places that set/clear receive_disabled,
> qemu_deliver_packet and qemu_flush_or_purge_queued_packets, but I
> think a new API is needed to implement the callback for hubs
> (qemu_send_enable/qemu_send_disable).

I think .can_receive is the harder one, I'm not sure it's feasible - each
device has its own set of conditions, so it will be a huge change.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]