[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] migration: Remove duplicated assignement of

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 1/3] migration: Remove duplicated assignement of SETUP status
Date: Wed, 20 May 2015 09:58:41 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 05/20/2015 09:35 AM, Juan Quintela wrote:
> We assign the MIGRATION_STATUS_SETUP status in two places.  Just in
> sucession.  Just remove the second one.


Where's the second place? Not in migrate_fd_connect...

okay, migrate_init() does the same thing, and I guess you're arguing
that it was always called either just before or just after
migrate_fd_connect can be called. But mentioning it in the commit
message would help.

> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  migration/migration.c | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]