[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qapi: add dirty bitmap status

From: John Snow
Subject: Re: [Qemu-devel] [PATCH] qapi: add dirty bitmap status
Date: Thu, 21 May 2015 17:48:30 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 05/20/2015 04:20 AM, Markus Armbruster wrote:
> John Snow <address@hidden> writes:
>> On 05/12/2015 04:06 PM, Eric Blake wrote:
>>> On 05/12/2015 01:53 PM, John Snow wrote:
>>>> Bitmaps can be in a handful of different states with potentially
>>>> more to come as we tool around with migration and persistence patches.
>>>> Instead of having a bunch of boolean fields, it was suggested that we
>>>> just have an enum status field that will help expose the reason to
>>>> management APIs why certain bitmaps may be unavailable for various
>>>> commands
>>>> (e.g. busy in another operation, busy being migrated, etc.)
>>> Might be worth mentioning that this is an API change, but safe because
>>> the old API is unreleased (and therefore, this patch MUST go in the 2.4
>>> time frame, if at all).
>>>> Suggested-by: Eric Blake <address@hidden>
>>>> Signed-off-by: John Snow <address@hidden>
>>>> ---
>>>>  block.c               | 13 ++++++++++++-
>>>>  include/block/block.h |  1 +
>>>>  qapi/block-core.json  | 23 +++++++++++++++++++++--
>>>>  3 files changed, 34 insertions(+), 3 deletions(-)
>>> Reviewed-by: Eric Blake <address@hidden>
>> I'm not actually sure whose tree this should go in. Markus's, perhaps?
>> ("ping")
> I guess the case for "Block layer core" (Kevin) is at least as strong as
> the case for "QAPI" (me).  Kevin, what do you think?

His silence says "Markus, can you please do it? I discovered today that
I don't care about this patch."


reply via email to

[Prev in Thread] Current Thread [Next in Thread]