[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 16/38] block/parallels: keep BAT bitmap data in littl
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 16/38] block/parallels: keep BAT bitmap data in little endian in memory |
Date: |
Fri, 22 May 2015 10:01:48 +0100 |
From: "Denis V. Lunev" <address@hidden>
This will allow to use this data as buffer to BAT update directly
without any intermediate buffers.
Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Roman Kagan <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Roman Kagan <address@hidden>
Message-id: address@hidden
CC: Kevin Wolf <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block/parallels.c | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index 1540c21..431adf1 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -90,7 +90,6 @@ static int parallels_open(BlockDriverState *bs, QDict
*options, int flags,
Error **errp)
{
BDRVParallelsState *s = bs->opaque;
- int i;
ParallelsHeader ph;
int ret;
@@ -143,10 +142,6 @@ static int parallels_open(BlockDriverState *bs, QDict
*options, int flags,
goto fail;
}
- for (i = 0; i < s->bat_size; i++) {
- le32_to_cpus(&s->bat_bitmap[i]);
- }
-
s->has_truncate = bdrv_has_zero_init(bs->file) &&
bdrv_truncate(bs->file, bdrv_getlength(bs->file)) == 0;
@@ -164,7 +159,7 @@ fail:
static int64_t bat2sect(BDRVParallelsState *s, uint32_t idx)
{
- return (uint64_t)s->bat_bitmap[idx] * s->off_multiplier;
+ return (uint64_t)le32_to_cpu(s->bat_bitmap[idx]) * s->off_multiplier;
}
static int64_t seek_to_sector(BDRVParallelsState *s, int64_t sector_num)
@@ -191,7 +186,7 @@ static int cluster_remainder(BDRVParallelsState *s, int64_t
sector_num,
static int64_t allocate_cluster(BlockDriverState *bs, int64_t sector_num)
{
BDRVParallelsState *s = bs->opaque;
- uint32_t idx, offset, tmp;
+ uint32_t idx, offset;
int64_t pos;
int ret;
@@ -215,12 +210,10 @@ static int64_t allocate_cluster(BlockDriverState *bs,
int64_t sector_num)
return ret;
}
- s->bat_bitmap[idx] = pos / s->off_multiplier;
-
- tmp = cpu_to_le32(s->bat_bitmap[idx]);
-
+ s->bat_bitmap[idx] = cpu_to_le32(pos / s->off_multiplier);
ret = bdrv_pwrite(bs->file,
- sizeof(ParallelsHeader) + idx * sizeof(tmp), &tmp, sizeof(tmp));
+ sizeof(ParallelsHeader) + idx * sizeof(s->bat_bitmap[idx]),
+ s->bat_bitmap + idx, sizeof(s->bat_bitmap[idx]));
if (ret < 0) {
s->bat_bitmap[idx] = 0;
return ret;
--
2.1.0
- [Qemu-devel] [PULL 08/38] block/parallels: mark parallels format driver as zero inited, (continued)
- [Qemu-devel] [PULL 08/38] block/parallels: mark parallels format driver as zero inited, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 06/38] block/parallels: provide _co_readv routine for parallels format driver, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 04/38] block/parallels: read up to cluster end in one go, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 09/38] block/parallels: _co_writev callback for Parallels format, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 11/38] block/parallels: support parallels image creation, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 10/38] iotests, parallels: test for write into Parallels image, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 12/38] iotests, parallels: test for newly created parallels image via qemu-img, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 13/38] parallels: change copyright information in the image header, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 14/38] block/parallels: rename catalog_ names to bat_, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 18/38] block/parallels: move parallels_open/probe to the very end of the file, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 16/38] block/parallels: keep BAT bitmap data in little endian in memory,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 15/38] block/parallels: create bat2sect helper, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 19/38] block/parallels: implement parallels_check method of block driver, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 17/38] block/parallels: read parallels image header and BAT into single buffer, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 20/38] block/parallels: implement incorrect close detection, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 21/38] iotests, parallels: check for incorrectly closed image in tests, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 24/38] block/parallels: delay writing to BAT till bdrv_co_flush_to_os, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 22/38] block/parallels: improve image reading performance, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 23/38] block/parallels: create bat_entry_off helper, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 26/38] block/parallels: optimize linear image expansion, Stefan Hajnoczi, 2015/05/22
- [Qemu-devel] [PULL 28/38] configure: handle clang -nopie argument warning, Stefan Hajnoczi, 2015/05/22