Re: [Qemu-devel] [PATCH 05/20] monitor: Use traditional command interface for HMP drive_del

[Eric Blake]

On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> All QMP commands use the "new" handler interface (mhandler.cmd_new).
> Most HMP commands still use the traditional interface (mhandler.cmd),
> but a few use the "new" one.  Complicates handle_user_command() for no
> gain, so I'm converting these to the traditional interface.
> 
> For drive_del, that's easy: hmp_drive_del() sheds its unused last
> parameter, and its return value, which the caller ignored anyway.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  blockdev.c                | 9 ++++-----
>  hmp-commands.hx           | 3 +--
>  include/sysemu/blockdev.h | 2 +-
>  3 files changed, 6 insertions(+), 8 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature