[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/20] monitor: Propagate errors through qmp_che
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 10/20] monitor: Propagate errors through qmp_check_input_obj() |
Date: |
Fri, 22 May 2015 16:20:55 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> monitor.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> @@ -4948,27 +4948,27 @@ static QDict *qmp_check_input_obj(QObject *input_obj)
> }
> } else if (!strcmp(arg_name, "id")) {
> /* FIXME: check duplicated IDs for async commands */
Is this comment dead, now that you killed async commands? If so, should
it be nuked earlier in the series?
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/20] monitor: Wean core off QError, and other cleanups, Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 03/20] monitor: Improve and document client_migrate_info protocol error, Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 08/20] monitor: Drop unused "new" HMP command interface, Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 10/20] monitor: Propagate errors through qmp_check_input_obj(), Markus Armbruster, 2015/05/22
- Re: [Qemu-devel] [PATCH 10/20] monitor: Propagate errors through qmp_check_input_obj(),
Eric Blake <=
- [Qemu-devel] [PATCH 12/20] monitor: Inline monitor_has_error() into its only caller, Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Markus Armbruster, 2015/05/22
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Eric Blake, 2015/05/22
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Markus Armbruster, 2015/05/26
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Gerd Hoffmann, 2015/05/26
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Daniel P. Berrange, 2015/05/26
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Markus Armbruster, 2015/05/26
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Gerd Hoffmann, 2015/05/26