[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 05/13] virtio-blk: Don't handle output when t

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v5 05/13] virtio-blk: Don't handle output when there is "device IO" op blocker
Date: Sat, 23 May 2015 17:27:46 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 20.05.2015 08:16, Fam Zheng wrote:
virtio-blk now listens to op blocker change of the associated block

Up on setting op blocker on BLOCK_OP_TYPE_DEVICE_IO:

    1) Set VirtIOBlock.paused
    2) In virtio_blk_handle_output, do nothing if VirtIOBlock.paused

    1) Clear the host event notifier
    2) In handle_notify, do nothing if VirtIOBlock.paused

Up on removing the op blocker:

    1) Clear VirtIOBlock.paused
    2) Schedule a BH on the AioContext of the backend, which calls
    virtio_blk_handle_output, so that the previous unhandled kicks can
    make progress

    1) Set the host event notifier
    2) Notify the host event notifier so that unhandled events are

Signed-off-by: Fam Zheng <address@hidden>
  hw/block/dataplane/virtio-blk.c | 25 ++++++++++++++++-
  hw/block/virtio-blk.c           | 59 +++++++++++++++++++++++++++++++++++++++--
  include/hw/virtio/virtio-blk.h  |  8 +++++-
  3 files changed, 88 insertions(+), 4 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]