[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed
Re: [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty()
Tue, 26 May 2015 17:51:08 +0200
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu)
On Tue 26 May 2015 05:39:12 PM CEST, Max Reitz <address@hidden> wrote:
>> After having emptied the cache, the data in the cache tables is no
>> longer useful, so we can tell the kernel that we are done with it. In
>> Linux this frees the resources associated with it.
> Looks good, but by applying the same logic, you could do the same call
> in qcow2_cache_create(). So what about it? :-)
But after qcow2_cache_create() the memory is still unused so this
doesn't have any affect.
> Also note that bdrv_commit() is used only by the HMP commit operation,
> not by QMP commit.
Thanks, I should probably clarify that in the commit message.
[Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Alberto Garcia, 2015/05/18