[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] docs/writing-qmp-commands: fix a typo

From: Michael Tokarev
Subject: Re: [Qemu-devel] [PATCH] docs/writing-qmp-commands: fix a typo
Date: Thu, 28 May 2015 15:27:04 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0

28.05.2015 15:12, Markus Armbruster wrote:
> Michael Tokarev <address@hidden> writes:
>> Marcus: I don't think such obvious and trivial changes needs to be re-sent
>> to -devel. Ofcourse it is better to send things to -devel rigth away, but
>> requiring to resent is a bit over the top.  I think anyway :)
> Patches must be posted to -devel for review.
> If you accept patches sent just to -trivial, then the only post to
> -devel will be your pull request, where it most probably won't get
> review.

Obvious typo fix in comment or doc don't really need a big review.
That's where the "too trivial" border can be drawn.

Just to be clear: I'm not, in any way, against posting things to -devel,
things SHOULD be posted to -devel.  But once a thing has been posted
like this one, just to -trivial, and it really _is_ trivial and obvious,
it is enough to say somehting among "This one is okay, but the next time
please send to -devel too".



> Judging from my own experience, no patch is too trivial to screw up.
> Play it safe, post to -devel for review always.  Resending a trivial
> patch isn't exactly a big burden :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]