[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/29] Fix memory leak relevant to calling qemu_

From: Michael Tokarev
Subject: Re: [Qemu-devel] [PATCH 00/29] Fix memory leak relevant to calling qemu_allocate_irqs
Date: Thu, 28 May 2015 15:34:16 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0

28.05.2015 15:08, Shannon Zhao wrote:
> From: Shannon Zhao <address@hidden>
> Before I sent some patches to fix memory leak spotted by valgrind and
> those are relevant to qemu_allocate_irqs. Then I find all the places
> calling this function through code searching and test by valgrind to
> check whether they have memory leak. These patches fix these memory leaks.
> Sorry that maybe the names of the patches are vertiginous while I could
> not find out better names and I try to sort them out.

Maybe a better subject will be "fix memory leak after qemu_allocate_irqs"
or something like that?  And for some, "use qemu_allocate_irq not _irqs
for single irq" -- this kind is sorta fun, I wonder why the codebase has
so many cases of this API misuse.

And one more question: do you really care that whole valgrind report is
included into every commit message? :)  All the recent patches you sent
(all the 3 recent "spotted by valgrind" series) are fine without these
reports which are the only info included in the commit message, I'd just
drop these reports like -ETOOMUCHINFO :)  Anyone disagree? :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]