[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/9] vl: Fail right after first bad -object

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 3/9] vl: Fail right after first bad -object
Date: Thu, 28 May 2015 08:52:46 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 05/28/2015 06:21 AM, Markus Armbruster wrote:
> Failure to create a -object is a fatal error.  However, we delay the

s/a -object/an -object/ ? (depends on whether you pronounce '-object' as
"object" or "dash-object")

> actual exit until all -object are processed.  On the one hand, this
> permits detection of genuine additional errors.  On the other hand, it
> can muddy the waters with uninteresting additional errors, e.g. when a
> later -object tries to reference a prior one that failed.
> We generally stop right on the first bad option, so do that for
> -object as well.
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  vl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]