[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache ent

From: Alberto Garcia
Subject: Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time
Date: Thu, 28 May 2015 17:19:22 +0200
User-agent: Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu)

On Thu 28 May 2015 05:14:12 PM CEST, Max Reitz wrote:
>>>>          'compat': 'str',
>>>>          '*lazy-refcounts': 'bool',
>>>>          '*corrupt': 'bool',
>>>> -      'refcount-bits': 'int'
>>>> +      'refcount-bits': 'int',
>>>> +      'cache-clean-interval': 'int'
>>>>      } }
>>> I'm not too happy about making this part of ImageInfoSpecificQCow2.
>>> Two reasons for this: First, it's eventually part of ImageInfo,
>>> which is defined as "Information about a QEMU image file", but this
>>> option cannot be set in the image file itself but is only a run-time
>>> option.
>> Can we mark the parameter optional, and only provide it when it is
>> non-zero?  That way, qemu-img (which cannot set an interval) will not
>> report it, and the only time it will appear is if it was set as part
>> of opening the block device under qemu.
> That sounds good.

But what do we do with the other parameters (refcount-cache-size,
l2-cache-size)? We cannot have the same solution there because they
don't belong to the image file either, and they're never going go be


reply via email to

[Prev in Thread] Current Thread [Next in Thread]