[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/9] Miscellaneous error reporting improvements

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH 0/9] Miscellaneous error reporting improvements
Date: Fri, 29 May 2015 10:51:54 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 28.05.2015 um 14:21 hat Markus Armbruster geschrieben:
> Touches vl.c, which gives me pretext to ask Paolo: would you be
> willing to take this through your tree?  Or should I take it through
> mine?

After this series we have an ugly half-converted state where
qemu_opts_foreach() has both a return code and an Error object,
and it's not generally true that an error is set for a failing
return code.

The most confusing part about this is that you have &error_abort almost
everywhere, but the function doesn't actually abort on error, but rather
returns a negative error code and leaves errp alone.

If you don't want to complete the conversion, can we add it to that wiki
page with the list half-done conversions at least?

Anyway, my opinion is only authoritative for the block layer, and that
part looks good, so for the blkdebug part:

Acked-by: Kevin Wolf <address@hidden>

PS: I would have preferred to be CCed on the whole series instead of
just a single patch. That one patch wasn't the only one that touched
blkdebug and it also wasn't quite enough to understand the context. So
CC on one patch is enough to make me aware of the series, but CC on the
whole series would also make it convenient to review it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]