[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 8/8] qemu-iotests: expand test 093 to support gr

From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 8/8] qemu-iotests: expand test 093 to support group throttling
Date: Fri, 29 May 2015 13:32:45 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, May 19, 2015 at 03:24:36PM +0300, Alberto Garcia wrote:
> @@ -32,26 +34,31 @@ class ThrottleTestCase(iotests.QMPTestCase):
>          raise Exception("Device not found for blockstats: %s" % device)
>      def setUp(self):
> -        self.vm = iotests.VM().add_drive(self.test_img)
> +        self.vm = iotests.VM()
> +        for i in range(0, self.max_drives):
> +            self.vm.add_drive(self.test_img)

Unique files are required, it's not safe to write to open the same image
file for writing multiple times.

This test case works with raw image files but could fail with image
formats like qcow2, vmdk, etc.  These image formats are not designed for
multiple writers and the test could fail early due to image file

Attachment: pgpyGrZTod3Ks.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]