Re: [Qemu-devel] [RFC v2 15/34] HACK: monitor: Comment out TCG profile ops

[Paolo Bonzini]

On 31/05/2015 08:11, Peter Crosthwaite wrote:
> Not dealing with this problem as of this RFC, but comments on how
> to solve it welcome. The approach adopted by this series is to
> implement multi-arch as multiple translators, so a single global
> TCG profiler is now ill-defined.

Probably some kind of tcg-common.c?  The counts can be added together
for all CPUs, and hence moved out of tcg_ctx.

Also for example tcg/tcg-opc.h should only depend on
TCG_TARGET_REG_BITS, i.e. not on the arch.  Hence tcg_op_defs should
also be arch-independent.

Paolo

> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>  monitor.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/monitor.c b/monitor.c
> index 1a17cf3..f3ee785 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -1036,13 +1036,17 @@ static void hmp_info_registers(Monitor *mon, const 
> QDict *qdict)
>  
>  static void hmp_info_jit(Monitor *mon, const QDict *qdict)
>  {
> +#if 0
>      dump_exec_info((FILE *)mon, monitor_fprintf);
> +#endif
>      dump_drift_info((FILE *)mon, monitor_fprintf);
>  }
>  
>  static void hmp_info_opcount(Monitor *mon, const QDict *qdict)
>  {
> +#if 0
>      dump_opcount_info((FILE *)mon, monitor_fprintf);
> +#endif
>  }
>  
>  static void hmp_info_history(Monitor *mon, const QDict *qdict)
>