qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC v2 23/34] arm: cpu: static inline cpu_arm_init


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [RFC v2 23/34] arm: cpu: static inline cpu_arm_init
Date: Mon, 01 Jun 2015 10:18:55 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0


On 31/05/2015 08:11, Peter Crosthwaite wrote:
> Move this implementation up to the header so it is visible from system
> level code once the architecture is converted to arch-obj-y. Alternative
> would be to create init.c in target-arm/hw but this implementation is
> trivial enough for static inline.
> 
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>  target-arm/cpu.h    | 6 +++++-
>  target-arm/helper.c | 5 -----
>  2 files changed, 5 insertions(+), 6 deletions(-)

I think there is something to win from consistency when you have a
partial transition, so perhaps target-arm/hw would be better despite the
simplicity of the function...

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]