Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries

[Kirk Allan]

 >>>

> 
> On 01/06/2015 23:19, Kirk Allan wrote:
>>> Elsewhere on the list, we've discussed putting extra cflags
>>> _after_ the configure-detected QEMU_CFLAGS.  This would fix the
>>> issue in the first part of this patch too.
>> 
>> By the time this portion of the configure script executes, any
>> --extra-cflags have already been rolled into the QEMU_CFLAGS.  Here
>> I'm just checking if WINVER is already contained in QEMU_CFLAGS.  If
>> it is not, then add WINVER=0x501 to the flags as it was done before.
>> If it's already contained in the QEMU_CFLAGS, just use what's there.
>> The only ordering difference would be WINVER now comes before
>> WIN32_LEAN_AND_MEAN.
> 
> If the extra cflags come last, they override the -DWINVER=0x501 that
> configure adds, and this patch isn't necessary anymore.

I was assuming that if you set _WIN32_WINNT=0x0600 (needed to gain access to 
the OnLinkPrefixLength field when running on Windows Vista/2008 and greater) 
you would also want to set WINVER=0x600 to match.  Having WINVER in the flags 
as both 501 and 600 causes configure errors.

Testing with _WIN32_WINNT=0x0600 and WINVER=0x501 seems to be ok.

I'll remove the first portion of the patch and just leave adding -liphlpapi.

> 
> Paolo