Re: [Qemu-devel] [PATCH v2 01/17] mips jazz: compile only in 64 bit little endian

[Hervé Poussineau]

Le 02/06/2015 13:02, Aurelien Jarno a écrit :
> On 2015-05-27 14:19, Hervé Poussineau wrote:
> > Remove now useless device models from other MIPS configurations
> >
> > We're now compiling 18 files less than before.
> >
> > Signed-off-by: Hervé Poussineau <address@hidden>
> > ---
> >   default-configs/mips-softmmu.mak     | 5 -----
> >   default-configs/mips64-softmmu.mak   | 5 -----
> >   default-configs/mips64el-softmmu.mak | 1 +
> >   default-configs/mipsel-softmmu.mak   | 5 -----
> >   hw/mips/Makefile.objs                | 3 ++-
> >   hw/mips/mips_jazz.c                  | 5 -----
> >   tests/endianness-test.c              | 4 ----
> >   7 files changed, 3 insertions(+), 25 deletions(-)
> >
> > diff --git a/default-configs/mips-softmmu.mak b/default-configs/mips-softmmu.mak
> > index cce2c81..f62a21a 100644
> > --- a/default-configs/mips-softmmu.mak
> > +++ b/default-configs/mips-softmmu.mak
> > @@ -21,14 +21,9 @@ CONFIG_PIIX4=y
> >   CONFIG_IDE_ISA=y
> >   CONFIG_IDE_PIIX=y
> >   CONFIG_NE2000_ISA=y
> > -CONFIG_RC4030=y
> > -CONFIG_DP8393X=y
> > -CONFIG_DS1225Y=y
> >   CONFIG_MIPSNET=y
> >   CONFIG_PFLASH_CFI01=y
> > -CONFIG_G364FB=y
> >   CONFIG_I8259=y
> > -CONFIG_JAZZ_LED=y
> >   CONFIG_MC146818RTC=y
> >   CONFIG_ISA_TESTDEV=y
> >   CONFIG_EMPTY_SLOT=y
> > diff --git a/default-configs/mips64-softmmu.mak 
> > b/default-configs/mips64-softmmu.mak
> > index 7a88a08..accedca 100644
> > --- a/default-configs/mips64-softmmu.mak
> > +++ b/default-configs/mips64-softmmu.mak
> > @@ -21,14 +21,9 @@ CONFIG_PIIX4=y
> >   CONFIG_IDE_ISA=y
> >   CONFIG_IDE_PIIX=y
> >   CONFIG_NE2000_ISA=y
> > -CONFIG_RC4030=y
> > -CONFIG_DP8393X=y
> > -CONFIG_DS1225Y=y
> >   CONFIG_MIPSNET=y
> >   CONFIG_PFLASH_CFI01=y
> > -CONFIG_G364FB=y
> >   CONFIG_I8259=y
> > -CONFIG_JAZZ_LED=y
> >   CONFIG_MC146818RTC=y
> >   CONFIG_ISA_TESTDEV=y
> >   CONFIG_EMPTY_SLOT=y
>
> TTBOMK, MIPS Magnum machines are dual endian, so why remove the 64-bit
> big endian version?
>
> On the other hand, I am all for removing the 32-bit versions.

Yes, MIPS Magnum are dual endian. However, they always start in little-endian 
mode, and firmware switches CPU to big-endian if required.
If you prefer that I keep the 64 bit big-endian variant, I can do it.

Regards,

Hervé