qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 3/4] monitor: Fix failure path for "S" argume


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v4 3/4] monitor: Fix failure path for "S" argument type
Date: Wed, 03 Jun 2015 13:32:43 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Bandan Das <address@hidden> writes:

> The "S" argument is only used with ? and we don't
> reach it. Fix it nevertheless.

"and we don't reach it" is confusing.  Suggest

    Since the "S" argument type is only used with the "?" flag, the bug
    can't bite.

With the commit message touched up:

Reviewed-by: Markus Armbruster <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]