qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/10 v11] arget-tilegx/opcode_tilegx.h: Modify


From: Chen Gang
Subject: Re: [Qemu-devel] [PATCH 05/10 v11] arget-tilegx/opcode_tilegx.h: Modify it to fit qemu using
Date: Wed, 3 Jun 2015 19:59:38 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0

On 06/03/2015 07:39 AM, Andreas Färber wrote:
> Am 03.06.2015 um 02:43 schrieb Peter Maydell:
>> On 30 May 2015 at 22:14, Chen Gang <address@hidden> wrote:
>>> Use 'inline' instead of '__inline', and also use 'uint64_t' instead of
>>> "unsigned long long"
>>>
>>> Signed-off-by: Chen Gang <address@hidden>
>>> ---
>>>  target-tilegx/opcode_tilegx.h | 220 
>>> +++++++++++++++++++++---------------------
>>>  1 file changed, 110 insertions(+), 110 deletions(-)
>>
>> Reviewed-by: Peter Maydell <address@hidden>
> 
> There's a "t" missing in the subject and the grammar is wrong - "usage"?
> Also "QEMU".
> 

OK, thank you very much.

> Deserves a mention in the commit message why this is not being squashed.
> 

Excuse me, my English is not quite well, I do not know about what you
said above, could you provide more details for it?

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed



reply via email to

[Prev in Thread] Current Thread [Next in Thread]