[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 05/23] target-i386: set G=1 in SMM big real mode
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH v2 05/23] target-i386: set G=1 in SMM big real mode selectors |
Date: |
Wed, 3 Jun 2015 19:08:30 +0200 |
Because the limit field's bits 31:20 is 1, G should be 1.
VMX actually enforces this, let's do it for completeness
in QEMU as well.
Signed-off-by: Paolo Bonzini <address@hidden>
---
target-i386/smm_helper.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/target-i386/smm_helper.c b/target-i386/smm_helper.c
index 6207c3a..5617a14 100644
--- a/target-i386/smm_helper.c
+++ b/target-i386/smm_helper.c
@@ -177,22 +177,22 @@ void do_smm_enter(X86CPU *cpu)
cpu_x86_load_seg_cache(env, R_CS, (env->smbase >> 4) & 0xffff, env->smbase,
0xffffffff,
DESC_P_MASK | DESC_S_MASK | DESC_W_MASK |
- DESC_A_MASK);
+ DESC_G_MASK | DESC_A_MASK);
cpu_x86_load_seg_cache(env, R_DS, 0, 0, 0xffffffff,
DESC_P_MASK | DESC_S_MASK | DESC_W_MASK |
- DESC_A_MASK);
+ DESC_G_MASK | DESC_A_MASK);
cpu_x86_load_seg_cache(env, R_ES, 0, 0, 0xffffffff,
DESC_P_MASK | DESC_S_MASK | DESC_W_MASK |
- DESC_A_MASK);
+ DESC_G_MASK | DESC_A_MASK);
cpu_x86_load_seg_cache(env, R_SS, 0, 0, 0xffffffff,
DESC_P_MASK | DESC_S_MASK | DESC_W_MASK |
- DESC_A_MASK);
+ DESC_G_MASK | DESC_A_MASK);
cpu_x86_load_seg_cache(env, R_FS, 0, 0, 0xffffffff,
DESC_P_MASK | DESC_S_MASK | DESC_W_MASK |
- DESC_A_MASK);
+ DESC_G_MASK | DESC_A_MASK);
cpu_x86_load_seg_cache(env, R_GS, 0, 0, 0xffffffff,
DESC_P_MASK | DESC_S_MASK | DESC_W_MASK |
- DESC_A_MASK);
+ DESC_G_MASK | DESC_A_MASK);
}
void helper_rsm(CPUX86State *env)
--
2.4.1
- [Qemu-devel] [PATCH v2 00/23] SMM improvements (chipset and TCG parts), Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 01/23] target-i386: introduce cpu_get_mem_attrs, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 03/23] target-i386: Use correct memory attributes for ioport accesses, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 05/23] target-i386: set G=1 in SMM big real mode selectors,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v2 02/23] target-i386: Use correct memory attributes for memory accesses, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 06/23] target-i386: wake up processors that receive an SMI, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 04/23] target-i386: mask NMIs on entry to SMM, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 07/23] pflash_cfi01: change big-endian property to BIT type, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors, Paolo Bonzini, 2015/06/03