[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 38/38] iotests: Add test for change-related Q
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 38/38] iotests: Add test for change-related QMP commands |
Date: |
Wed, 03 Jun 2015 15:46:59 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/03/2015 01:44 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/118 | 638
> +++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/118.out | 5 +
> tests/qemu-iotests/group | 1 +
> 3 files changed, 644 insertions(+)
> create mode 100755 tests/qemu-iotests/118
> create mode 100644 tests/qemu-iotests/118.out
>
> + def test_tray_open_change(self):
> + result = self.vm.qmp('blockdev-open-tray', device='drive0',
> force=True)
> + self.assert_qmp(result, 'return', {})
> +
> + self.wait_for_open()
> +
> + result = self.vm.qmp('query-block')
> + self.assert_qmp(result, 'return[0]/tray_open', True)
> + if self.was_empty == True:
Stylistically, isn't 'if self.was_empty:' equivalent? But I'm no python
guru, so I can live with the test as you have it.
> +++ b/tests/qemu-iotests/group
> @@ -121,6 +121,7 @@
> 114 rw auto quick
> 115 rw auto
> 116 rw auto quick
> +118 rw auto
> 121 rw auto
Wow - we've got several placeholders pending review :)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 31/38] blockdev: Implement change with basic operations, (continued)
- [Qemu-devel] [PATCH v3 31/38] blockdev: Implement change with basic operations, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 32/38] block: Inquire tray state before tray-moved events, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 34/38] hmp: Use blockdev-change-medium for change command, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 33/38] qmp: Introduce blockdev-change-medium, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 35/38] blockdev: read-only-mode for blockdev-change-medium, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 37/38] iotests: More options for VM.add_drive(), Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 36/38] hmp: Add read-only-mode option to change command, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 38/38] iotests: Add test for change-related QMP commands, Max Reitz, 2015/06/03
- Re: [Qemu-devel] [PATCH v3 38/38] iotests: Add test for change-related QMP commands,
Eric Blake <=