[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 1/4] monitor: remove debug prints
From: |
Bandan Das |
Subject: |
[Qemu-devel] [PATCH v5 1/4] monitor: remove debug prints |
Date: |
Wed, 3 Jun 2015 18:38:07 -0400 |
The preferred solution is to use tracepoints and there
is good chance of bitrot with the debug prints not being
enabled at compile time. Remove them.
Suggested-by: Markus Armbruster <address@hidden>
Signed-off-by: Bandan Das <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
---
monitor.c | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/monitor.c b/monitor.c
index b2561e1..cc4e7d1 100644
--- a/monitor.c
+++ b/monitor.c
@@ -81,9 +81,6 @@
#endif
#include "hw/lm32/lm32_pic.h"
-//#define DEBUG
-//#define DEBUG_COMPLETION
-
/*
* Supported types:
*
@@ -3707,10 +3704,6 @@ static const mon_cmd_t *monitor_parse_command(Monitor
*mon,
char buf[1024];
char *key;
-#ifdef DEBUG
- monitor_printf(mon, "command='%s', start='%d'\n", cmdline, start);
-#endif
-
/* extract the command name */
p = get_command_name(cmdline + start, cmdname, sizeof(cmdname));
if (!p)
@@ -4189,10 +4182,7 @@ static void file_completion(Monitor *mon, const char
*input)
path[input_path_len] = '\0';
pstrcpy(file_prefix, sizeof(file_prefix), p + 1);
}
-#ifdef DEBUG_COMPLETION
- monitor_printf(mon, "input='%s' path='%s' prefix='%s'\n",
- input, path, file_prefix);
-#endif
+
ffs = opendir(path);
if (!ffs)
return;
@@ -4770,14 +4760,6 @@ static void monitor_find_completion(void *opaque,
if (parse_cmdline(cmdline, &nb_args, args) < 0) {
return;
}
-#ifdef DEBUG_COMPLETION
- {
- int i;
- for (i = 0; i < nb_args; i++) {
- monitor_printf(mon, "arg%d = '%s'\n", i, args[i]);
- }
- }
-#endif
/* if the line ends with a space, it means we want to complete the
next arg */
--
2.1.0
- [Qemu-devel] [PATCH v5 0/4] monitor: suggest running "help" for command errors, Bandan Das, 2015/06/03
- [Qemu-devel] [PATCH v5 1/4] monitor: remove debug prints,
Bandan Das <=
- [Qemu-devel] [PATCH v5 2/4] monitor: cleanup parsing of cmd name and cmd arguments, Bandan Das, 2015/06/03
- [Qemu-devel] [PATCH v5 4/4] monitor: Fix failure path for "S" argument, Bandan Das, 2015/06/03
- [Qemu-devel] [PATCH v5 3/4] monitor: Point to "help" command on syntax error, Bandan Das, 2015/06/03
- Re: [Qemu-devel] [PATCH v5 0/4] monitor: suggest running "help" for command errors, Markus Armbruster, 2015/06/08
- Re: [Qemu-devel] [PATCH v5 0/4] monitor: suggest running "help" for command errors, Markus Armbruster, 2015/06/16