[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND v1 3/8] target-microblaze: Convert endi t
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH RESEND v1 3/8] target-microblaze: Convert endi to a CPU property |
Date: |
Fri, 5 Jun 2015 10:40:25 +1000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jun 04, 2015 at 11:22:42AM +1000, Alistair Francis wrote:
> Originally the endi PVR bits were manually set for each machine. This
> is a hassle and difficult to read, instead set them based on the CPU
> properties.
>
> Signed-off-by: Alistair Francis <address@hidden>
> ---
> hw/microblaze/petalogix_ml605_mmu.c | 2 +-
> target-microblaze/cpu-qom.h | 1 +
> target-microblaze/cpu.c | 4 +++-
> target-microblaze/cpu.h | 2 +-
> 4 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/hw/microblaze/petalogix_ml605_mmu.c
> b/hw/microblaze/petalogix_ml605_mmu.c
> index 995a579..5f341c4 100644
> --- a/hw/microblaze/petalogix_ml605_mmu.c
> +++ b/hw/microblaze/petalogix_ml605_mmu.c
> @@ -70,7 +70,6 @@ static void machine_cpu_reset(MicroBlazeCPU *cpu)
>
> env->pvr.regs[10] = 0x0e000000; /* virtex 6 */
> /* setup pvr to match kernel setting */
> - env->pvr.regs[0] |= PVR0_ENDI;
> env->pvr.regs[0] = (env->pvr.regs[0] & ~PVR0_VERSION_MASK) | (0x14 << 8);
> env->pvr.regs[4] = 0xc56b8000;
> env->pvr.regs[5] = 0xc56be000;
> @@ -99,6 +98,7 @@ petalogix_ml605_init(MachineState *machine)
> object_property_set_int(OBJECT(cpu), 1, "use-fpu", &error_abort);
> object_property_set_bool(OBJECT(cpu), true, "dcache-writeback",
> &error_abort);
> + object_property_set_bool(OBJECT(cpu), true, "endi", &error_abort);
> object_property_set_bool(OBJECT(cpu), true, "realized", &error_abort);
>
> /* Attach emulated BRAM through the LMB. */
> diff --git a/target-microblaze/cpu-qom.h b/target-microblaze/cpu-qom.h
> index af6739f..85b8f75 100644
> --- a/target-microblaze/cpu-qom.h
> +++ b/target-microblaze/cpu-qom.h
> @@ -66,6 +66,7 @@ typedef struct MicroBlazeCPU {
> uint8_t usefpu;
> bool usemmu;
> bool dcache_writeback;
> + bool endi;
> } cfg;
>
> CPUMBState env;
> diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
> index 2a1ff64..f40df43 100644
> --- a/target-microblaze/cpu.c
> +++ b/target-microblaze/cpu.c
> @@ -114,7 +114,8 @@ static void mb_cpu_realizefn(DeviceState *dev, Error
> **errp)
>
> env->pvr.regs[0] |= (cpu->cfg.stackprot ? PVR0_SPROT_MASK : 0) |
> (cpu->cfg.usefpu ? PVR0_USE_FPU_MASK : 0) |
> - (cpu->cfg.usemmu ? PVR0_USE_MMU_MASK : 0);
> + (cpu->cfg.usemmu ? PVR0_USE_MMU_MASK : 0) |
> + (cpu->cfg.endi ? PVR0_ENDI_MASK : 0);
>
> env->pvr.regs[2] |= (cpu->cfg.usefpu ? PVR2_USE_FPU_MASK : 0) |
> (cpu->cfg.usefpu > 1 ? PVR2_USE_FPU2_MASK : 0);
> @@ -174,6 +175,7 @@ static Property mb_properties[] = {
> DEFINE_PROP_BOOL("use-mmu", MicroBlazeCPU, cfg.usemmu, true),
> DEFINE_PROP_BOOL("dcache-writeback", MicroBlazeCPU, cfg.dcache_writeback,
> false),
> + DEFINE_PROP_BOOL("endi", MicroBlazeCPU, cfg.endi, false),
Oh BTW, this should be endianness to match the dts bindings...
> DEFINE_PROP_END_OF_LIST(),
> };
>
> diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h
> index 36d5120..88e6a2a 100644
> --- a/target-microblaze/cpu.h
> +++ b/target-microblaze/cpu.h
> @@ -124,7 +124,7 @@ typedef struct CPUMBState CPUMBState;
> #define PVR0_USE_DCACHE_MASK 0x01000000
> #define PVR0_USE_MMU_MASK 0x00800000
> #define PVR0_USE_BTC 0x00400000
> -#define PVR0_ENDI 0x00200000
> +#define PVR0_ENDI_MASK 0x00200000
> #define PVR0_FAULT 0x00100000
> #define PVR0_VERSION_MASK 0x0000FF00
> #define PVR0_USER1_MASK 0x000000FF
> --
> 1.7.1
>
[Qemu-devel] [PATCH v1 5/8] target-microblaze: Convert pvr-full to a CPU property, Alistair Francis, 2015/06/03