[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-ca
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc |
Date: |
Wed, 17 Jun 2015 16:13:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 17/06/2015 16:11, Michael S. Tsirkin wrote:
> On Fri, Jun 12, 2015 at 10:05:47AM -0400, Don Slutz wrote:
>> Changes v6 to v7:
>> Rebase to master
>>
>> Fixed a bug caused by commit c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 now
>> patch #1
>
>> Added patch #2 to switch to using trace in vm,port.c.
>>
>> Delay call on g_strndup till after key length check.
>>
>> Switched e-mail address in MAINTAINERS.
>>
>> Eric Blake
>> Why not assert(find) instead of leaving it to the comment?
>> Switch to assert.
>> Is it worth marking arg const here and in the VMPortRpcFind struct
>> Switch to const.
>> I'd rather abort() if someone compiled with -NDEBUG
>> Done.
>> Still mismatches on ---- line length (several sites).
>> Done
>>
>>
>> Changes v5 to v6:
>>
>> Rebase to master
>>
>> Eric Blake
>> Returning a non-dictionary is not extensible.
>> Added new type VmportGuestInfoValue.
>> s/VmportGuestInfo/VmportGuestInfoKey/
>> s/type/struct/
>> Issues with examples
>> Fixed.
>>
>>
>> Changes v4 to v5:
>>
>> Paolo Bonzini
>> What is VMPORT_SHORT about?
>> Dropped this.
>> Why not use a bool in CPUX86State?
>> Took his sugestion and moved to a bool in X86CPU.
>>
>> Changes v3 to v4:
>>
>> Paolo Bonzini on "vmort_rpc: Add QMP access to vmport_rpc"
>> Does this compile on non-x86 targets?
>> Nope. Fixed.
>>
>> Changes v2 to v3:
>>
>> s/2.3/2.4
>>
>> Changes v1 to v2:
>>
>> Added live migration code.
>> Adjust data structures for migration.
>> Switch to GHashTable.
>>
>> Eric Blake
>> s/spawened/spawned/
>> Done
>> s/traceing/tracing/
>> Done
>> Change "error_set(errp, ERROR_CLASS_GENERIC_ERROR, " to
>> "error_setg(errp, "
>> Done
>> Why two commands (inject-vmport-reboot, inject-vmport-halt)?
>> Switched to inject-vmport-action.
>> format=base64 "bug" statements.
>> Dropped.
>>
>> Much more on format=base64:
>>
>> If there is a bug it is in GLIB. However the Glib reference manual
>> refers to RFC 1421 and RFC 2045 and MIME encoding. Based on all
>> that (which seems to match:
>>
>> http://en.wikipedia.org/wiki/Base64
>>
>> ) MIME states that all characters outside the (base64) alphabet are
>> to be ignored. Testing shows that g_base64_decode() does this.
>>
>> The confusion is that most non-MIME uses reject a base64 string that
>> contain characters outside the alphabet. I was just following the
>> other uses of base64 in this file.
>>
>> DataFormat refers to RFC 3548, which has the info:
>>
>> "
>> Implementations MUST reject the encoding if it contains
>> characters outside the base alphabet when interpreting base
>> encoded data, unless the specification referring to this document
>> explicitly states otherwise. Such specifications may, as MIME
>> does, instead state that characters outside the base encoding
>> alphabet should simply be ignored when interpreting data ("be
>> liberal in what you accept").
>> "
>>
>> So with GLIB going the MIME way, I do not think this is a QEMU bug
>> (you could consider this a GLIB bug, but the document I found says
>> that GLIB goes the MIME way and so does not reject anything).
>
> To me it looks like this will break cross-version migration as you are
> adding a bunch of devices unconditionally. Will it not?
Yes, that's what was done for parallel and pcspk as well. There's no
infrastructure to avoid it.
Paolo
- [Qemu-devel] [PATCH v7 6/9] vmport_rpc: Add QMP access to vmport_rpc object., (continued)
- [Qemu-devel] [PATCH v7 6/9] vmport_rpc: Add QMP access to vmport_rpc object., Don Slutz, 2015/06/12
- [Qemu-devel] [PATCH v7 7/9] vmport_rpc: Add migration, Don Slutz, 2015/06/12
- [Qemu-devel] [PATCH v7 5/9] vmport_rpc: Add limited support of VMware's hyper-call rpc, Don Slutz, 2015/06/12
- [Qemu-devel] [PATCH v7 8/9] vmport: Add VMware all ring hack, Don Slutz, 2015/06/12
- [Qemu-devel] [PATCH v7 4/9] vmport_rpc: Add the object vmport_rpc, Don Slutz, 2015/06/12
- [Qemu-devel] [PATCH v7 9/9] MAINTAINERS: add VMware port, Don Slutz, 2015/06/12
- Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc, Paolo Bonzini, 2015/06/17
- Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc, Michael S. Tsirkin, 2015/06/17
- Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc, Michael S. Tsirkin, 2015/06/17
- Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc, Paolo Bonzini, 2015/06/17
- Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc, Michael S. Tsirkin, 2015/06/17
- Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc, Paolo Bonzini, 2015/06/17
- Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc, Michael S. Tsirkin, 2015/06/17
- Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc, Paolo Bonzini, 2015/06/17
- Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc, Michael S. Tsirkin, 2015/06/17
- Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc, Paolo Bonzini, 2015/06/17
- Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc, Michael S. Tsirkin, 2015/06/17
- Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc, Paolo Bonzini, 2015/06/17