[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends |
Date: |
Wed, 17 Jun 2015 09:50:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/17/2015 05:48 AM, Markus Armbruster wrote:
> "Kővágó Zoltán" <address@hidden> writes:
>
>> 2015-06-17 09:46 keltezéssel, Markus Armbruster írta:
>>> Copying Eric for additional QAPI schema expertise.
>>>
>>>> +{ 'struct': 'Audiodev',
>>>> + 'data': {
>>>> + '*id': 'str',
>>>> + 'in': 'AudiodevPerDirectionOptions',
>>>> + 'out': 'AudiodevPerDirectionOptions',
>>>> + '*timer-period': 'int',
>>>> + 'opts': 'AudiodevBackendOptions' } }
>>>
>>> Have you considered making this a flat union, similar ro
>>> BlockdevOptions?
>>
>> Not really. If you qapi masters out there think it's better, then I
>> will convert it.
>
> Related: discussion about flattening in review of PATCH 2.
Indeed - I think a flat union makes for nicer command line structure,
and fewer {} nesting in QMP structure. I still need to spend time on
the overall thread, but wanted to chime in on this comment up front.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends, (continued)
- [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends, Kővágó, Zoltán, 2015/06/16
- Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends, Markus Armbruster, 2015/06/17
- Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends, Kővágó Zoltán, 2015/06/17
- Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends, Markus Armbruster, 2015/06/17
- Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends, Kővágó Zoltán, 2015/06/17
- Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends, Markus Armbruster, 2015/06/17
- Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends, Kővágó Zoltán, 2015/06/17
- Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends, Markus Armbruster, 2015/06/17
- Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends, Kővágó Zoltán, 2015/06/17
- Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends, Markus Armbruster, 2015/06/18
- Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends,
Eric Blake <=
[Qemu-devel] [PATCH v2 4/6] qapi: AllocVisitor, Kővágó, Zoltán, 2015/06/16
[Qemu-devel] [PATCH v2 5/6] audio: use qapi AudioFormat instead of audfmt_e, Kővágó, Zoltán, 2015/06/16
[Qemu-devel] [PATCH v2 6/6] audio: -audiodev command line option, Kővágó, Zoltán, 2015/06/16