[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/8] Add a member in MachineState to store ir
From: |
Shannon Zhao |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/8] Add a member in MachineState to store irq array |
Date: |
Thu, 18 Jun 2015 18:29:42 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 2015/6/17 15:30, Michael Tokarev wrote:
> 17.06.2015 05:59, Shannon Zhao wrote:
>> From: Shannon Zhao <address@hidden>
>>
>> These are relevant to memory leak in machine init function. Here we add
>> a member in MachineState to store irq array returned from
>> qemu_allocate_irqs.
>>
>> PS. These patches are split from my previous patchset [1] since they are
>> relevant to MachineState.
>>
>> Thanks,
>> Shannon
>>
>> [1] [PATCH 00/29] Fix memory leak relevant to calling qemu_allocate_irqs
>>
>> changes since v2:
>> * Rebased on QEMU upstream
>> * Add a member in MachineState first, then fix the memory leak [mjt]
>
> Um. This is not what I asked. It was a small suggestion, to add
> infrastructure first use it in subsequent patches.
>
> But the main question was what this infrastructure, what this patchset
> actually brings us? You just store the irq pointer in machine state,
> that's okay, but WHAT FOR? If your intention is to free resources,
> this intention isn't met. The end result of this whole change is a no-op,
> there's nothing changed, the memory which has been allocated isn't being
> freed.
>
Ok, will rethink about.
> So the actual question is: what's the point of this patchset?
>
> Thanks,
>
> /mjt
>
>
> .
>
--
Shannon
- [Qemu-devel] [PATCH v3 4/8] hw/m68k/an5206.c: Store irq array in MachineState to fix memory leak, (continued)
- [Qemu-devel] [PATCH v3 4/8] hw/m68k/an5206.c: Store irq array in MachineState to fix memory leak, Shannon Zhao, 2015/06/16
- [Qemu-devel] [PATCH v3 3/8] hw/sparc/leon3.c: Store irq array in MachineState to fix memory leak, Shannon Zhao, 2015/06/16
- [Qemu-devel] [PATCH v3 5/8] hw/sh4/r2d.c: Store irq array in MachineState to fix memory leak, Shannon Zhao, 2015/06/16
- [Qemu-devel] [PATCH v3 6/8] hw/arm/palm.c: Store irq array in MachineState to fix memory leak, Shannon Zhao, 2015/06/16
- [Qemu-devel] [PATCH v3 8/8] hw/arm/tosa.c: Store irq array in MachineState to fix memory leak, Shannon Zhao, 2015/06/16
- [Qemu-devel] [PATCH v3 7/8] hw/arm/spitz.c: Store irq array in MachineState to fix memory leak, Shannon Zhao, 2015/06/16
- [Qemu-devel] [PATCH v3 1/8] include/hw/boards.h: Add a member in MachineState to store irq array, Shannon Zhao, 2015/06/16
- [Qemu-devel] [PATCH v3 2/8] hw/ppc/ppc440_bamboo.c: Store irq array in MachineState to fix memory leak, Shannon Zhao, 2015/06/16
- Re: [Qemu-devel] [PATCH v3 0/8] Add a member in MachineState to store irq array, Michael Tokarev, 2015/06/17
- Re: [Qemu-devel] [PATCH v3 0/8] Add a member in MachineState to store irq array,
Shannon Zhao <=