qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 0/8] More core code ENV_GET_CPU removals


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH v3 0/8] More core code ENV_GET_CPU removals
Date: Thu, 18 Jun 2015 16:22:20 -0300
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Jun 18, 2015 at 10:24:47AM -0700, Peter Crosthwaite wrote:
> Hi All,
> 
> I'm moving towards the goal of having no core code usages of ENV_GET_CPU.
> This has two advantages:
> 
> 1: It means we are closer to common-obj'ing core code like exec.c, cpus.c
> and friends.
> 2: Multi arch is easier if ENV_GET_CPU() stays arch specific. It means I
> don't need those patches where I reorder the env within the arch specific
> CPUState. This allows continuing placement of arch specifics before the
> env in the CPU container (which has TCG perf advantages).
> 
> Due to point 1, I'm sending this ahead as I think it has standalone value,
> rather than send as part of multi-arch.

Series doesn't apply cleanly on top of latest qemu.git (commit
8ffe756d), due to a small conflict on patch 1/8 (on target-arm/cpu.c).
What's the commit ID you used as base for the series?

Probably there's no need to resend, though, as "git am -3" seems to
handle the conflict properly.

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]