[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 2/9] iohandler: Use aio code
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 2/9] iohandler: Use aio code |
Date: |
Fri, 19 Jun 2015 09:05:06 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, 06/16 14:57, Stefan Hajnoczi wrote:
> On Wed, Jun 10, 2015 at 04:59:44PM +0800, Fam Zheng wrote:
> > diff --git a/iohandler.c b/iohandler.c
> > index 826f713..f5d7704 100644
> > --- a/iohandler.c
> > +++ b/iohandler.c
> > @@ -32,111 +32,39 @@
> > #include <sys/wait.h>
> > #endif
> >
> > -typedef struct IOHandlerRecord {
> > - IOHandler *fd_read;
> > - IOHandler *fd_write;
> > - void *opaque;
> > - QLIST_ENTRY(IOHandlerRecord) next;
> > - int fd;
> > - int pollfds_idx;
> > - bool deleted;
> > -} IOHandlerRecord;
> > +static AioContext *iohandler_ctx;
>
> Please include a comment explaining why this AioContext is needed in
> addition to the global qemu_aio_context.
OK!
It's needed because iohandlers shouldn't be polled by aio_poll().
Fam
- [Qemu-devel] [PATCH 0/9] slirp: iohandler: Rebase onto aio, Fam Zheng, 2015/06/10
- [Qemu-devel] [PATCH 1/9] aio: Introduce aio_set_fd_handler_pri, Fam Zheng, 2015/06/10
- [Qemu-devel] [PATCH 2/9] iohandler: Use aio code, Fam Zheng, 2015/06/10
- [Qemu-devel] [PATCH 3/9] main-loop: Move include of "qemu/sockets.h" to libslirp.h, Fam Zheng, 2015/06/10
- [Qemu-devel] [PATCH 4/9] slirp: Remove dead code for "PROBE_CONN", Fam Zheng, 2015/06/10
- [Qemu-devel] [PATCH 6/9] slirp: Move icmp socket to iohandler, Fam Zheng, 2015/06/10
- [Qemu-devel] [PATCH 5/9] slirp: Add "poll_events" to struct socket, Fam Zheng, 2015/06/10
- [Qemu-devel] [PATCH 8/9] slirp: Move tcb socket to iohandler, Fam Zheng, 2015/06/10
- [Qemu-devel] [PATCH 7/9] slirp: Move udb socket to iohandler, Fam Zheng, 2015/06/10
- [Qemu-devel] [PATCH 9/9] slirp: Remove unused pollfds from the parameter list, Fam Zheng, 2015/06/10