[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 01/14] qom: strdup() target property name on objec
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PULL v3 01/14] qom: strdup() target property name on object_property_add_alias() |
Date: |
Fri, 19 Jun 2015 19:24:34 +0200 |
From: Eduardo Habkost <address@hidden>
With this, object_property_add_alias() callers can safely free the
target property name, like what already happens with the 'name' argument
to all object_property_add*() functions.
Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
qom/object.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index 96abd34..d142d15 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1705,7 +1705,7 @@ void object_property_add_uint64_ptr(Object *obj, const
char *name,
typedef struct {
Object *target_obj;
- const char *target_name;
+ char *target_name;
} AliasProperty;
static void property_get_alias(Object *obj, struct Visitor *v, void *opaque,
@@ -1736,6 +1736,7 @@ static void property_release_alias(Object *obj, const
char *name, void *opaque)
{
AliasProperty *prop = opaque;
+ g_free(prop->target_name);
g_free(prop);
}
@@ -1763,7 +1764,7 @@ void object_property_add_alias(Object *obj, const char
*name,
prop = g_malloc(sizeof(*prop));
prop->target_obj = target_obj;
- prop->target_name = target_name;
+ prop->target_name = g_strdup(target_name);
op = object_property_add(obj, name, prop_type,
property_get_alias,
--
2.1.4
- [Qemu-devel] [PULL v2 00/14] QOM devices patch queue 2015-06-19, Andreas Färber, 2015/06/19
- [Qemu-devel] [PULL v3 14/14] qdev: Un-deprecate qdev_init_nofail(), Andreas Färber, 2015/06/19
- [Qemu-devel] [PULL v3 05/14] backends: Fix typename of 'policy' enum property in hostmem obj, Andreas Färber, 2015/06/19
- [Qemu-devel] [PULL v3 01/14] qom: strdup() target property name on object_property_add_alias(),
Andreas Färber <=
- [Qemu-devel] [PULL v3 02/14] qdev: Free property names after registering gpio aliases, Andreas Färber, 2015/06/19
- [Qemu-devel] [PULL v3 12/14] qom: Don't pass string table to object_get_enum() function, Andreas Färber, 2015/06/19
- [Qemu-devel] [PULL v3 07/14] vl: Create (most) objects before creating chardev backends, Andreas Färber, 2015/06/19
- [Qemu-devel] [PULL v3 08/14] qom: Add helper function for getting user objects root, Andreas Färber, 2015/06/19
- [Qemu-devel] [PULL v3 06/14] doc: Document user creatable object types in help text, Andreas Färber, 2015/06/19
- [Qemu-devel] [PULL v3 13/14] qdev: Deprecated qdev_init() is finally unused, drop, Andreas Färber, 2015/06/19
- [Qemu-devel] [PULL v3 11/14] qom: Add an object_property_add_enum() helper function, Andreas Färber, 2015/06/19
- [Qemu-devel] [PULL v3 10/14] qom: Make enum string tables const-correct, Andreas Färber, 2015/06/19
- [Qemu-devel] [PULL v3 09/14] qom: Add object_new_with_props() / object_new_withpropv() helpers, Andreas Färber, 2015/06/19
- [Qemu-devel] [PULL v3 03/14] tests: Use qtest_add_data_func() consistently, Andreas Färber, 2015/06/19