[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 06/16] ahci: add ncq debug checks
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH v2 06/16] ahci: add ncq debug checks |
Date: |
Mon, 22 Jun 2015 19:38:18 -0400 |
Most of the time, these bits can be safely ignored. For the purposes
of debugging however, it's nice to know that they're not being used.
Signed-off-by: John Snow <address@hidden>
---
hw/ide/ahci.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 14961a0..c2e6642 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1003,6 +1003,25 @@ static void process_ncq_command(AHCIState *s, int port,
uint8_t *cmd_fis,
(uint64_t)ncq_fis->lba0;
ncq_tfs->tag = tag;
+ /* Sanity-check the NCQ packet */
+ if (tag != slot) {
+ DPRINTF(port, "Warn: NCQ slot (%d) did not match the given tag (%d)\n",
+ slot, tag);
+ }
+
+ if (ncq_fis->aux0 || ncq_fis->aux1 || ncq_fis->aux2 || ncq_fis->aux3) {
+ DPRINTF(port, "Warn: Attempt to use NCQ auxiliary fields.\n");
+ }
+ if (ncq_fis->prio || ncq_fis->icc) {
+ DPRINTF(port, "Warn: Unsupported attempt to use PRIO/ICC fields\n");
+ }
+ if (ncq_fis->fua & NCQ_FIS_FUA_MASK) {
+ DPRINTF(port, "Warn: Unsupported attempt to use Force Unit Access\n");
+ }
+ if (ncq_fis->tag & NCQ_FIS_RARC_MASK) {
+ DPRINTF(port, "Warn: Unsupported attempt to use Rebuild Assist\n");
+ }
+
ncq_tfs->sector_count = ((uint16_t)ncq_fis->sector_count_high << 8) |
ncq_fis->sector_count_low;
ahci_populate_sglist(ad, &ncq_tfs->sglist, 0);
@@ -1016,6 +1035,10 @@ static void process_ncq_command(AHCIState *s, int port,
uint8_t *cmd_fis,
ncq_err(ncq_tfs);
ahci_trigger_irq(ad->hba, ad, PORT_IRQ_OVERFLOW);
return;
+ } else if (ncq_tfs->sglist.size != size) {
+ DPRINTF(port, "Warn: PRDTL (0x%zx)"
+ " does not match requested size (0x%zx)",
+ ncq_tfs->sglist.size, size);
}
DPRINTF(port, "NCQ transfer LBA from %"PRId64" to %"PRId64", "
--
2.1.0
- [Qemu-devel] [PATCH v2 00/16] ahci: ncq cleanup, part 1, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 01/16] ahci: Rename NCQFIS structure fields, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 03/16] ahci: add ncq_err helper, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 04/16] ahci: check for ncq prdtl overflow, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 02/16] ahci: use shorter variables, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 06/16] ahci: add ncq debug checks,
John Snow <=
- [Qemu-devel] [PATCH v2 05/16] ahci: separate prdtl from opts, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 07/16] ahci: ncq sector count correction, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 08/16] ahci/qtest: Execute IDENTIFY prior to data commands, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 09/16] libqos/ahci: fix cmd_sanity for ncq, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 10/16] libqos/ahci: add NCQ frame support, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 11/16] libqos/ahci: edit wait to be ncq aware, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 12/16] libqos/ahci: adjust expected NCQ interrupts, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 14/16] libqos/ahci: Force all NCQ commands to be LBA48, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 13/16] libqos/ahci: set the NCQ tag on command_commit, John Snow, 2015/06/22
- [Qemu-devel] [PATCH v2 16/16] qtest/ahci: ncq migration test, John Snow, 2015/06/22