Re: [Qemu-devel] [PULL v2 58/60] qdev: add 64bit properties

[Gonglei]

On 2015/6/23 14:55, Markus Armbruster wrote:
> Gonglei <address@hidden> writes:
> 
>> On 2015/6/21 5:10, Paolo Bonzini wrote:
>>>
>>>
>>> On 01/06/2015 14:25, Michael S. Tsirkin wrote:
>>>> +static uint64_t qdev_get_prop_mask64(Property *prop)
>>>> +{
>>>> +    assert(prop->info == &qdev_prop_bit);
>>>> +    return 0x1 << prop->bitnr;
>>>
>>> This needs to be 1ull.
>>>
>> Yes, and coverity spot it and some other OVERRUN problems.
> 
> Patch author(s) know?
> 
> Or are you taking care of them?
> 
I have already posted a patch and Cc'd Gerd.

Regards,
-Gonglei