|
From: | Marc-André Lureau |
Subject: | Re: [Qemu-devel] [PATCH 39/39] tests: Add ivshmem qtest |
Date: | Fri, 26 Jun 2015 18:02:50 +0200 |
Please don't use HTML mails, that breaks quoting as you can see below.
Am 26.06.2015 um 17:27 schrieb Marc-André Lureau:
> On Fri, Jun 26, 2015 at 5:08 PM, Andreas Färber <address@hidden
> <mailto:address@hidden>> wrote:
>
>
> For the second time within days you're posting a patch for something
> that's been on the list already... The commit message above is entirely
>
>
> Sorry which patch are you refering to?
This one vs. my http://patchwork.ozlabs.org/patch/336367/
And my "[PATCH for-2.3? 0/7] tests: Fix TCG make test" series vs.
your http://patchwork.ozlabs.org/patch/487719/
> Is it wrong to repost a old patch and adding, while adding signoff and
> modifications?
> (what I just did in this series for David patches)
"contrib: add ivshmem client and server" looks (formally) okay except
for the final [...], which should go before your Signed-off-by.
That's not what you've done here though, as I complained. You did not
ask me about the state of my patch either before you posted this.
> Tbh, your patch was just launching one instance of qemu with ivshmem. If you
> look at the one I proposed, you'll notice that it is completely
> different: I don't think your
> signoff or copyright should be added here.
Well, I disagree. Extending a test case does not give you the right to
replace SUSE with Red Hat. Makes it look like an NIH problem.
Also, see the discussion on my RFC: CONFIG_LINUX is wrong here. It would
need to depend on KVM/eventfd, and for that there is no easy config
option available here, which stopped my patch at the time.
[Prev in Thread] | Current Thread | [Next in Thread] |