Re: [Qemu-devel] [PATCH v2 07/12] Rework ram_control_load_hook to hook during block load

[Juan Quintela]

"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Michael R. Hines (address@hidden) wrote:

>> >  qemu_rdma_registration_handle_unregister_success(uint64_t chunk) "%" 
>> > PRIu64
>> >-qemu_rdma_registration_handle_wait(uint64_t flags) "Waiting for next 
>> >request %" PRIu64
>> >+qemu_rdma_registration_handle_wait(void) ""
>> 
>> Are you using some kind of script to generate these trace prototypes?
>> What happened to the message? =)
>
> The prototypes I added manually.  You normally have the trace name in your
> tool so you don't need the text that gives you the same piece of information.
> So I get output like:
>
> address@hidden:qemu_rdma_registration_handle_ram_blocks 
>
> without having to write anything in the text.
> (That's with the stderr trace backend, and the prefix being PID and time)

Notice also that he removed the flags argument on the caller function,
so nothing to print there, really.


>
> Dave
>
>> 
>> >  qemu_rdma_registration_start(uint64_t flags) "%" PRIu64
>> >  qemu_rdma_registration_stop(uint64_t flags) "%" PRIu64
>> >  qemu_rdma_registration_stop_ram(void) ""
>> 
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK