Re: [Qemu-devel] [PATCH RFC 0/4] vGICv3 support

[Daniel P. Berrange]

On Wed, Jul 01, 2015 at 12:21:12PM +0200, Christoffer Dall wrote:
> On Fri, May 22, 2015 at 01:58:40PM +0300, Pavel Fedin wrote:
> >  This is my alternative to Ashok's vGICv3 patch
> > (https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg03021.html), which
> > i am currently working on. It addresses vGIC capability verification issue
> > (kvm_irqchip_create() / kvm_arch_irqchip_create()), as well as offers better
> > code structure (v3 code separated from v2).
> >  This patchset applies on top of this:
> > https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg00943.html. Note 
> > that
> > GIC type selection still relies on machine name (virt-v3 vs virt), and not 
> > on
> > machine option. Since libvirt has recently introduced support for extra 
> > options,
> > i have absolutely nothing against Ashok's approach. I just did not change 
> > this
> > yet because it would affect my testing environment. The aim of this RFC is 
> > to
> > focus on vGICv3 implementation and related changes. And yes, i agree that 
> > v2 and
> > v3 now have some copypasted code, and this is TBD.
> 
> This cover letter is not really helpful as it only describes the history
> and circumstances of how this patch came to be.
> 
> It would be helpful if the beginning of this cover letter focuses on
> what the patch series does and which design decisions have been taken to
> shape the patches the way they are.
> 
> I don't understand the whole background thing about libvirt and I don't

I replied to the earlier posting of the patch series that the quoted
libvirt limitation does not exist any longer, so that really should
not be mentioned as a problem/rationale for the machine type approach
anymore. I agree with Peter GICv3 should be selected based on properties
not new machine types.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|