[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] ne2000: Drop ne2000_can_receive
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2] ne2000: Drop ne2000_can_receive |
Date: |
Fri, 3 Jul 2015 11:41:38 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jul 03, 2015 at 09:08:41AM +0800, Fam Zheng wrote:
> This moves the behavior of ne2000_can_receive to ne2000_receive. The
> logic is when the NIC is stopped we drop the packet, when the buffer is
> full we queue it and try flush later.
>
> ne2000_buffer_full is determined by s->curpag, s->boundary, s->start and
> s->stop. Add a flush in ne2000_ioport_write as they are all updated
> there, except the advancing of s->curpag in ne2000_receive where
> ne2000_buffer_full is already false.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> hw/net/ne2000-isa.c | 1 -
> hw/net/ne2000.c | 27 ++++++++++++++++-----------
> 2 files changed, 16 insertions(+), 12 deletions(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
pgpJnFtnlMyYS.pgp
Description: PGP signature