|
| From: | Edgar E. Iglesias |
| Subject: | Re: [Qemu-devel] [PATCH for-2.4] hw/intc/arm_gic_common.c: Reset all registers |
| Date: | Sat, 4 Jul 2015 22:38:02 +1000 |
On 04/07/2015 9:24 pm, "Peter Maydell" <address@hidden> wrote:
>
> On 4 July 2015 at 00:11, Edgar E. Iglesias <address@hidden> wrote:
> >
> >
> > On Tue, Jun 30, 2015 at 4:25 AM, Peter Maydell <address@hidden>
> > wrote:
> >>
> >> The arm_gic_common reset function was missing reset code for
> >> several of the GIC's state fields:
> >> * bpr[]
> >> * abpr[]
> >> * priority1[]
> >> * priority2[]
> >> * sgi_pending[]
> >> * irq_target[] (SMP configurations only)
> >>
> >> These probably went unnoticed because most guests will either
> >> never touch them, or will write to them in the process of
> >> configuring the GIC before enabling interrupts.
> >>
> >> Signed-off-by: Peter Maydell <address@hidden>
> >
> >
> >
> > Reviewed-by: Edgar E. Iglesias <address@hidden>
>
> I assume you meant to send that to the list? :-)
Yes sorry :-)
Cheers,
Edgar
>
> Thanks for the review.
>
> -- PMM
| [Prev in Thread] | Current Thread | [Next in Thread] |