|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH v5 08/11] target-i386: exception handling for seg_helper functions |
Date: | Mon, 6 Jul 2015 13:13:30 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 07/06/2015 09:26 AM, Pavel Dovgalyuk wrote:
This patch fixes exception handling for seg_helper functions. Signed-off-by: Pavel Dovgalyuk <address@hidden>
No, you don't want to discriminately change every call. That was my original point about not needing to change seg_helper.c or smm_helper.c.
Further, any such changes would go along with the changes in translate.c to remove the state saving there.
I would only change those that are "normal" memory operations, like fp loads etc. The segmentation changes are rare. The task state helpers require state saving anyway, so requiring a TCG search is a pessimization.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |