Re: [Qemu-devel] [PATCH 06/10] qga: guest exec functionality for Windows guests

[Denis V. Lunev]

On 07/07/15 12:12, Olga Krishtal wrote:
> On 07/07/15 11:06, Denis V. Lunev wrote:
> > On 07/07/15 04:31, Michael Roth wrote:
> > > Quoting Denis V. Lunev (2015-06-30 05:25:19)
> > > > From: Olga Krishtal <address@hidden>
> > > >
> > > > Child process' stdin/stdout/stderr can be associated
> > > > with handles for communication via read/write interfaces.
> > > >
> > > > The workflow should be something like this:
> > > > * Open an anonymous pipe through guest-pipe-open
> > > > * Execute a binary or a script in the guest. Arbitrary arguments and
> > > >    environment to a new child process could be passed through options
> > > > * Read/pass information from/to executed process using
> > > >    guest-file-read/write
> > > > * Collect the status of a child process
> > > Have you seen anything like this in your testing?
> > >
> > > {'execute':'guest-exec','arguments':{'path':'/Windows/System32/ipconfig.exe', 
> > >
> > >   'timeout':5000}}
> > > {"return": {"pid": 588}}
> > > {'execute':'guest-exec-status','arguments':{'pid':588}}
> > > {"return": {"exit": 0, "handle-stdout": -1, "handle-stderr": -1,
> > >   "handle-stdin": -1, "signal": -1}}
> > > {'execute':'guest-exec-status','arguments':{'pid':588}}
> > > {"error": {"class": "GenericError", "desc": "Invalid parameter 'pid'"}}
> > >
> > > {'execute':'guest-exec','arguments':{'path':'/Windows/System32/ipconfig.exe', 
> > >
> > >   'timeout':5000}}
> > > {"error": {"class": "GenericError", "desc": "CreateProcessW() failed:
> > >   The parameter is incorrect. (error: 57)"}}
> > > {'execute':'guest-exec','arguments':{'path':'/Windows/System32/ipconfig.exe', 
> > >
> > >   'timeout':5000}}
> > > {"error": {"class": "GenericError", "desc": "CreateProcessW() failed:
> > >   The parameter is incorrect. (error: 57)"}}
> First if all what version of Windows are you using?
> Secondly, you do need to specify environmental variable:
> sudo virsh qemu-agent-command w2k12r2 
> '{"execute":"guest-exec","arguments":{"path":"/Windows/System32/ipconfig.exe", 
> "timeout": 5000, "env":["MyEnv=00"]}' :

Argh.... I have missed this fact during internal discussion and review.
For sure this should be passed to the client. I think that it would
be better to add this automatically to the environment variables
passed to the exec arguments.

> For Windows Server 2003 we do not have to pass "env" at all, but if we 
> are working with Server 2008 and older we have to pass "env" = "00" if 
> we do not want to use it. 
> https://social.msdn.microsoft.com/Forums/windowsdesktop/en-US/ 
> 59450592-aa52-4170-9742-63c84bff0010/unexpected-errorinvalidparameter 
> -returned-by-createprocess-too-bad?forum=windowsgeneraldevelopmentissues
> This comment where included in first version of patches and I may have 
> forgotten it. Try to specify env and call exec several times. It 
> should work fine.
> I will look closer at guest-exec-status double call.